[Solved] Cannot implicitly convert type 'Microsoft.AspNetCore.Mvc.BadRequestObjectResult'

I've created an endpoint in my ASP.NET Core application's controller to return customer details. I intended to use this endpoint from the client application. However, when I call the endpoint, I encounter this error: "Cannot implicitly convert type 'Microsoft.AspNetCore.Mvc.BadRequestObjectResult' to 'System.Collections.Generic.IList'. An explicit conversion exists (are you missing a cast?)"

[HttpGet("GetActiveCustomersForUser")]
[ProducesResponseType(200)]
[ProducesResponseType(404)]
public async Task<IList<Customer>> GetActiveCustomersForUser(string customerId = "")
{
    if (string.IsNullOrEmpty(customerId))
    {
        customerId = HttpContext.User.FindFirstValue(ClaimTypes.Sid);
    }
    return await _customerRepository.GetAll(customerId, false);
}

We noticed that our action return type doesn't account for the possibility of returning a BadRequest. To address this, instead of directly using IList, we should wrap it with the generic ActionResult type.

Action method:

 public async Task<ActionResult<IList<Customer>>> GetActiveCustomersForUser(string customerId = "")

By using ActionResult, we allow for the flexibility of returning not only the desired IList but also other types of results like BadRequest, NotFound, etc. depending on the scenario.

The error "Cannot implicitly convert type 'Microsoft.AspNetCore.Mvc.BadRequestObjectResult'", it typically means that there's a mismatch between the expected return type and the actual return type in our code and to resolve this, we need to ensure that the return type of our action method matches the expected return type specified in our code.

Example:

Let's say we have an action method in our controller that is expected to return a BadRequestObjectResult:


    [HttpPost]
    public IActionResult CreateActionMethod(MyModel model)
    {
        if (!ModelState.IsValid)
        {
            return BadRequest(ModelState);
        }
        
       
        
        return Ok();
    }

In above code example, if we mistakenly return something other than a BadRequestObjectResult when ModelState is not valid, such as returning an OkResult, we'll encounter the mentioned error.

Let's consider an example using a Teacher model. Suppose we have a Teacher model class like this:


    public class Teacher
    {
        public int Id { get; set; }
        public string Name { get; set; }
        public string Subject { get; set; }
    
    }

And we have an action method in our controller that handles the creation of a new teacher:


    [HttpPost]
    public IActionResult CreateTeacher(Teacher teacher)
    {
        if (!ModelState.IsValid)
        {
            return BadRequest(ModelState);
        }
        
    
        return Ok();
    }

In this example, if ModelState is not valid, we correctly return a BadRequestObjectResult containing the ModelState errors.

[Solved] Cannot implicitly convert type 'Microsoft.AspNetCore.Mvc.BadRequestObjectResult'

Example:

Read Similar Articles